Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI - new hosts, step 1 updates #329

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

kialj876
Copy link
Collaborator

Issue:

  • bcgov/entity/issues/

Description of changes:

  • updates for fee things
  • locale stuff
  • address stuff

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).

@kialj876 kialj876 requested a review from deetz99 November 21, 2024 22:15
Copy link
Collaborator

@deetz99 deetz99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

Signed-off-by: Kial Jinnah <[email protected]>
@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-strata-hotel-dev--pr-329-113dd7cx.web.app

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-platform-dev--pr-329-76l27d3s.web.app

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kialj876 ts vs json for locales, just curious your opinion?

@thorwolpert thorwolpert merged commit 5171bf4 into bcgov:main Nov 22, 2024
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants