Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Platform/Strata - UI: Strata text updates and minor fixes #324

Merged
merged 9 commits into from
Nov 20, 2024

Conversation

deetz99
Copy link
Collaborator

@deetz99 deetz99 commented Nov 20, 2024

Issue:

Description of changes:

  • update strata text based on doc
  • swap moment for luxon date library
  • fix email in info collection modal
  • fix email layout on review page of platforms app
  • add days to expiry and last status change column in strata dashboard list
Screenshot 2024-11-20 at 9 59 03 AM Screenshot 2024-11-20 at 9 58 41 AM Screenshot 2024-11-20 at 9 57 37 AM

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
10.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-platform-dev--pr-324-8v6q4hlg.web.app

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-strata-hotel-dev--pr-324-plbptbvh.web.app

Copy link
Collaborator

@kialj876 kialj876 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work this all looks good to me 👍

@deetz99 deetz99 merged commit 4b24102 into bcgov:main Nov 20, 2024
21 of 22 checks passed
@deetz99 deetz99 deleted the strata-text branch November 20, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants