EDX-3094: Bug fix

bcgov · Jan 7, 2025 · 713618f · 713618f
1 parent 3380815
commit 713618f
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 11 deletions.
diff --git a/backend/src/components/sdc/sdc.js b/backend/src/components/sdc/sdc.js
@@ -378,6 +378,8 @@ function mapPenMatchResult(penMatchResult) {
     return 'Review Requested';
   case 'MULTI':
     return 'Multiple PEN Matches';
+  case 'CONFLICT':
+    return 'Conflict';
   default:
     return penMatchResult;
   }
@@ -435,7 +437,7 @@ function createAssignedPENSearchCriteria(searchParams) {
   let searchCriteriaList = [];
 
   if(searchParams.label === 'REVIEW_PEN') {
-    searchCriteriaList.push({ key: 'penMatchResult', operation: FILTER_OPERATION.IN, value: 'MULTI,INREVIEW', valueType: VALUE_TYPE.STRING, condition: CONDITION.AND });
+    searchCriteriaList.push({ key: 'penMatchResult', operation: FILTER_OPERATION.IN, value: 'MULTI,INREVIEW,CONFLICT', valueType: VALUE_TYPE.STRING, condition: CONDITION.AND });
   } else if(searchParams.label === 'NEW_PEN') {
     searchCriteriaList.push({ key: 'penMatchResult', operation: FILTER_OPERATION.IN, value: 'NEW', valueType: VALUE_TYPE.STRING, condition: CONDITION.AND });
   }

diff --git a/frontend/src/components/data-collection/PenMatchStudentDetails.vue b/frontend/src/components/data-collection/PenMatchStudentDetails.vue
@@ -246,6 +246,7 @@ export default {
         'MULTI' : '#7737BD',
         'MATCH' : '#2E8540',
         'NEW' : '#2E8540',
+        'CONFLICT' : '#7737BD'
       },
       showPenRequestDialog: false,
       showPenMatchDialog: false,
@@ -304,9 +305,6 @@ export default {
       this.setNavigationPage(index);
       this.$router.push({name: 'student-detail', params: {studentID: this.selectedIDs[index]}});
     },
-    navigate() {
-      this.getSdcSchoolCollectionStudentDetail(this.selectedIDs[this.page - 1]);
-    },
     isLoading() {
       return this.loadingCount > 0;
     },
@@ -342,7 +340,6 @@ export default {
           });
         }
         this.title = `${this.possibleMatches.length || 0} Matches`;
-        this.isStudentDataUpdated = false; // pen match result is refreshed now enable the table.
       } catch (error) {
         console.log(error);
         this.setFailureAlert('PEN Match API call failed, please try again.');
@@ -377,7 +374,11 @@ export default {
       this.clonedStudentDetail.assignedStudentId = matchedStudent.studentID;
       this.updatePEN('MATCH').finally(() => {
         this.isMatchingToStudentRecord = false;
-        this.getSdcSchoolCollectionStudentDetail(this.$route.params.studentID);
+        if(!this.nextDisabled) {
+          this.clickNextBtn();
+        } else {
+          this.getSdcSchoolCollectionStudentDetail(this.$route.params.studentID);
+        }
       });
     },
     async saveNewPen(newPenDetails) {
@@ -387,7 +388,11 @@ export default {
       this.updatePEN('NEW').finally(() => {
         this.isIssuingNewPen = false;
         this.togglePENRequestDialog();
-        this.getSdcSchoolCollectionStudentDetail(this.$route.params.studentID);
+        if(!this.nextDisabled) {
+          this.clickNextBtn();
+        } else {
+          this.getSdcSchoolCollectionStudentDetail(this.$route.params.studentID);
+        }
       });
     },
     async updatePEN(type) {
@@ -398,10 +403,6 @@ export default {
           } else {
             this.setSuccessAlert('PEN has been MATCHED successfully.');
           }
-          
-          if(!this.nextDisabled) {
-              this.clickNextBtn();
-          }
         })
         .catch(error => {
           this.setFailureAlert(error?.response?.data?.message ? error?.response?.data?.message : 'An error occurred while updating PEN. Please try again later.');
@@ -431,6 +432,8 @@ export default {
           return 'Review Requested';
         case 'MULTI':
           return 'Multiple PEN Matches';
+        case 'CONFLICT':
+          return 'Conflict';
         case 'NEW':
           return 'New PEN Assigned';
         case 'MATCH':