fix: code smells

bcgov · Oct 23, 2023 · 032512b · 032512b
1 parent f36c436
commit 032512b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/backend/src/components/edx/exchange.js b/backend/src/components/edx/exchange.js
@@ -1093,7 +1093,7 @@ async function createSchool(req, res) {
 
     const {school, user} = req.body;
     const userHasEmptyVals = Object.values(user)
-      .reduce((result, currentValue) => result ? result : isEmptyString(currentValue), false);
+      .reduce((result, currentValue) => result || isEmptyString(currentValue), false);
 
     const payload = {
       school: set('districtId')(school.districtID)(

diff --git a/frontend/src/utils/institute/formRules.js b/frontend/src/utils/institute/formRules.js
@@ -88,9 +88,9 @@ const requiredWithOtherFieldValues = (
   fieldValues = [],
   message = 'Please fulfill all related fields.'
 ) => {
-  const toAnyFieldHasValue = (result, currentValue) => result ? result : !!(currentValue && currentValue.trim());
+  const toAnyFieldHasValue = (result, currentValue) => result || !!(currentValue?.trim());
   return v => {
-    const thisFieldIsEmpty = !(v && v.trim());
+    const thisFieldIsEmpty = !(v?.trim());
     const fieldsContainValues = fieldValues.reduce(toAnyFieldHasValue, false);
     return thisFieldIsEmpty && fieldsContainValues ? message : true;
   };