GRAD2-3064 - Refactor institute endpoints in EDUC-GRAD-TRAX-API #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
api/src/main/java/ca/bc/gov/educ/api/trax/service/institute/SchoolService.java
Dismissed
Show dismissed
Hide dismissed
api/src/main/java/ca/bc/gov/educ/api/trax/service/institute/SchoolService.java
Dismissed
Show dismissed
Hide dismissed
api/src/main/java/ca/bc/gov/educ/api/trax/service/institute/SchoolService.java
Dismissed
Show dismissed
Hide dismissed
api/src/main/java/ca/bc/gov/educ/api/trax/service/institute/SchoolService.java
Dismissed
Show dismissed
Hide dismissed
infstar
reviewed
Nov 27, 2024
| @PreAuthorize(PermissionsConstants.READ_SCHOOL_DATA) | ||
| @Operation(summary = "Find School Details by Mincode from cache", description = "Get School Details by Mincode from cache", tags = { "School" }) | ||
| @ApiResponses(value = {@ApiResponse(responseCode = "200", description = "OK"), | ||
| @ApiResponse(responseCode = "204", description = "NO CONTENT")}) | ||
| public ResponseEntity<SchoolDetail> getSchoolDetailsByMincode(@PathVariable String minCode) { | ||
| public ResponseEntity<SchoolDetail> getSchoolDetailsByParams(@RequestParam(required = false) String minCode) { | ||
| log.debug("getSchoolDetails V2 : "); |
There was a problem hiding this comment.
Just minor... the same log as getSchoolDetailsById at line 131 makes me hard to trace in debug mode.
There was a problem hiding this comment.
Added proper Debug messages.
|
infstar
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GRAD2-3064 - Refactor institute endpoints in EDUC-GRAD-TRAX-API