Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating to brod 3.16 and new kafka resp schemas #100

Merged
merged 5 commits into from
Nov 21, 2021

Conversation

jeffgrunewald
Copy link
Collaborator

Restructure the create, list and delete topic API to allow updating to brod 3.16 which migrates to a new structure for the underlying kafka_protocol response schemas which underwent a substantial change from the previous brod <= 3.14 versions.

Also cleans up the now-deprecated :crypto.rand_uniform/2 API in the random partitioner in favor of the new :rand.uniform/1 function.

@tpitale
Copy link

tpitale commented Nov 21, 2021

🎉 shall I close the other PR #99?

@jeffgrunewald
Copy link
Collaborator Author

🎉 shall I close the other PR #99?

Sure; thanks for pointing out the changes there as they weren’t handled in the same location as the other kpro schema changes. And no, I don’t think we’re super concerned with maintaining complete backward compatibility; I think a a good majority of kafka users are likely using some form of managed kafka and thus keeping up to date so rolling the brod/kpro version forward as well seems reasonable and the alternative was going to make the version handling in the Topics module pretty messy and potentially reduce throughout because we’d have to add more round trips to query the api version to know how to handle each request. If you look at kpro’s different schema versions there’s absolutely no consistency between versions for any given req/rsp api.

@jeffgrunewald jeffgrunewald merged commit 53eb831 into master Nov 21, 2021
@jeffgrunewald jeffgrunewald deleted the upgrade_brod_3_16 branch November 21, 2021 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants