Handle partition response format for newer brod #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @jdenen @jeffgrunewald Any chance you could review/merge this? |
jeffgrunewald
approved these changes
Nov 20, 2021
|
Yeah, there are a fair few changes in Kafka protocol and the responses returned. I haven't catalogued them all. I made some of the changes in brod, so I could probably try to compare my own PR to what is used in Elsa. But so far, this is the only thing our app has encountered with a mostly reading workload. Would you like to maintain compatibility with pre-3.16 brod? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #97