Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create an example of the kind of link tree Node users must create #603

Merged
merged 8 commits into from
Sep 13, 2022
Merged

Create an example of the kind of link tree Node users must create #603

merged 8 commits into from
Sep 13, 2022

Conversation

aiuto
Copy link
Collaborator

@aiuto aiuto commented Jul 20, 2022 •
edited
Loading

This just creates the tool to make the kind of test data that simulates an NPM treey.

See #115 for context.

@aiuto aiuto requested a review from nacl as a code owner July 20, 2022 03:43
@aiuto aiuto mentioned this pull request Jul 20, 2022
Open
@aiuto aiuto marked this pull request as draft July 20, 2022 03:43
@aiuto aiuto changed the title Create an example of the kind of link tree Node users muse create Create an example of the kind of link tree Node users must create Jul 26, 2022
@aiuto aiuto marked this pull request as ready for review August 4, 2022 14:48
@aiuto aiuto requested a review from jylinv0 August 30, 2022 21:46
@aiuto aiuto requested a review from cgrindel September 9, 2022 19:07
cgrindel
cgrindel approved these changes Sep 10, 2022
View reviewed changes
Copy link
Collaborator

@cgrindel cgrindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a couple of questions in the review comment.

pkg/private/pkg_files.bzl Outdated Show resolved Hide resolved
tests/util/defs.bzl Show resolved Hide resolved
tests/util/defs.bzl Outdated Show resolved Hide resolved
@aiuto aiuto merged commit 46eabd3 into bazelbuild:main Sep 13, 2022
@aiuto
Copy link
Collaborator Author

aiuto commented Sep 13, 2022

Thanks for the review.

@aiuto aiuto deleted the rellink branch September 13, 2022 03:58
@aiuto aiuto mentioned this pull request Sep 14, 2022
Open
@dpward dpward mentioned this pull request Oct 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgrindel cgrindel cgrindel approved these changes

@nacl nacl Awaiting requested review from nacl

@jylinv0 jylinv0 Awaiting requested review from jylinv0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aiuto @cgrindel