-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rules_proto 6.0.0.bcr.1 #2137
Conversation
This is the same as 6.0.0 but rules_cc is not a dev dep bazelbuild/rules_proto#211
Hello @googleberg, @zhangskz, @alexeagle, @thesayyn, modules you maintain (rules_proto) have been updated in this PR. Please review the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to avoid forking from the upstream, I think we're just an escalation away from finding someone to press merge...
yea we can do that if we want, my worry was about the release schedule after that |
I think it would be useful for discussing when we want to do this type of thing vs wait, since there isn't an easy way for downstream deps, outside of main projects, to unblock without merging something like this |
If all we patch is the module file I think that's totally acceptable, at least until Bzlmod is upstream's default setup. |
that is the case in this PR |
It's just so lame that we can't get a one line change in after 27 days so BCR starts to fork. Anyway I'll get off my soap box |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. Please take a final look to merge this PR.
This is the same as 6.0.0 but rules_cc is not a dev dep bazelbuild/rules_proto#211
This is the same as 6.0.0 but rules_cc is not a dev dep bazelbuild/rules_proto#211
This is the same as 6.0.0 but rules_cc is not a dev dep
bazelbuild/rules_proto#211