Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rules_proto 6.0.0.bcr.1 #2137

Merged
merged 1 commit into from
May 29, 2024
Merged

Add rules_proto 6.0.0.bcr.1 #2137

merged 1 commit into from
May 29, 2024

Conversation

keith
Copy link
Member

@keith keith commented May 28, 2024

This is the same as 6.0.0 but rules_cc is not a dev dep

bazelbuild/rules_proto#211

This is the same as 6.0.0 but rules_cc is not a dev dep

bazelbuild/rules_proto#211
@bazel-io
Copy link
Member

Hello @googleberg, @zhangskz, @alexeagle, @thesayyn, modules you maintain (rules_proto) have been updated in this PR. Please review the changes.

@keith keith enabled auto-merge (squash) May 28, 2024 18:26
Copy link
Contributor

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to avoid forking from the upstream, I think we're just an escalation away from finding someone to press merge...

@keith
Copy link
Member Author

keith commented May 28, 2024

yea we can do that if we want, my worry was about the release schedule after that

@keith keith disabled auto-merge May 28, 2024 20:17
@keith
Copy link
Member Author

keith commented May 28, 2024

I think it would be useful for discussing when we want to do this type of thing vs wait, since there isn't an easy way for downstream deps, outside of main projects, to unblock without merging something like this

@fmeum
Copy link
Contributor

fmeum commented May 28, 2024

If all we patch is the module file I think that's totally acceptable, at least until Bzlmod is upstream's default setup.

@keith
Copy link
Member Author

keith commented May 28, 2024

that is the case in this PR

@alexeagle
Copy link
Contributor

It's just so lame that we can't get a one line change in after 27 days so BCR starts to fork. Anyway I'll get off my soap box

Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. Please take a final look to merge this PR.

@fmeum fmeum merged commit d28305c into main May 29, 2024
20 checks passed
@fmeum fmeum deleted the ks/add-rules_proto-6.0.0.bcr.1 branch May 29, 2024 06:45
aiuto pushed a commit to aiuto/bazel-central-registry that referenced this pull request Jun 3, 2024
This is the same as 6.0.0 but rules_cc is not a dev dep

bazelbuild/rules_proto#211
zaucy pushed a commit to zaucy/bazel-central-registry that referenced this pull request Jun 14, 2024
This is the same as 6.0.0 but rules_cc is not a dev dep

bazelbuild/rules_proto#211
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants