Skip to content

Commit

Permalink
Support more valid ios_application kwargs (#803)
Browse files Browse the repository at this point in the history
Adds support for `codesign_inputs`, `codesignopts` and `toolchains`
  • Loading branch information
luispadron authored Nov 7, 2023
1 parent 459d8ad commit d6ad676
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 1 deletion.
5 changes: 4 additions & 1 deletion rules/app.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,10 @@ _IOS_APPLICATION_KWARGS = [
"app_icons",
"bundle_id",
"bundle_name",
"entitlements",
"codesign_inputs",
"codesignopts",
"entitlements_validation",
"entitlements",
"env",
"executable_name",
"extensions",
Expand All @@ -36,6 +38,7 @@ _IOS_APPLICATION_KWARGS = [
"strings",
"tags",
"test_host",
"toolchains",
"version",
"visibility",
]
Expand Down
18 changes: 18 additions & 0 deletions tests/ios/app/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -446,3 +446,21 @@ ios_application(
"//tests/ios/frameworks/testonly:SwiftLibrary",
],
)

ios_application(
name = "AppWithDisabledCodesigning",
srcs = ["App/main.m"],
bundle_id = "com.example.app",
codesign_inputs = ["@build_bazel_rules_apple//tools/codesigningtool:disable_signing_resource_rules"],
codesignopts = [
"--digest-algorithm=sha1",
"--resource-rules=$(RESOURCE_RULES)",
],
minimum_os_version = "10.0",
toolchains = ["@build_bazel_rules_apple//tools/codesigningtool:disable_signing_resource_rules"],
visibility = ["//visibility:public"],
deps = [
":FW",
":OnlySources",
],
)

0 comments on commit d6ad676

Please sign in to comment.