Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bazel-gazelle (to allow + in repo names) (for bazel 8) #97

Merged
merged 8 commits into from
Dec 14, 2024

Conversation

kriscfoster
Copy link
Contributor

@kriscfoster kriscfoster commented Dec 11, 2024

This is required for bazel 8 compatibility.

Currently hitting failed to parse cquery result: label parse error: repository has invalid characters: "@@rules_python++python+python_3_11_x86_64-unknown-linux-gnu//:python_runtimes".

This should be fixed by bazel-contrib/bazel-gazelle#1856.

@kriscfoster kriscfoster changed the title Update bazel-gazelle (to allow + in repo names) Update bazel-gazelle (to allow + in repo names) (for bazel 8) Dec 11, 2024
@illicitonion
Copy link
Collaborator

Thanks for the contribution! I agree with the goal, but unfortunately the update seems to be failing on CI... I pushed a couple of commits trying to fix things, but no joy! If you can get things green, I'm happy to merge!

@kriscfoster
Copy link
Contributor Author

Thanks for the contribution! I agree with the goal, but unfortunately the update seems to be failing on CI... I pushed a couple of commits trying to fix things, but no joy! If you can get things green, I'm happy to merge!

Thanks. I think I'm pretty close now (one test failure left). I'll let you know here once I'm ready for a review.

@kriscfoster
Copy link
Contributor Author

Tests are passing now @illicitonion. It took some time to debug a strange regression (I think) caused by bazel-contrib/bazel-gazelle#1911 (mainly in vendor/github.com/bazelbuild/buildtools/labels/labels.go).

I know the work-around isn't the cleanest but it's all that I have time to do right now.

Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for persisting through this! Just one small change to think about/do and let's get this merged!

pkg/target_determinator.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@illicitonion illicitonion enabled auto-merge (squash) December 14, 2024 13:28
@illicitonion illicitonion merged commit a86186e into bazel-contrib:main Dec 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants