-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bazel-gazelle (to allow +
in repo names) (for bazel 8)
#97
Update bazel-gazelle (to allow +
in repo names) (for bazel 8)
#97
Conversation
+
in repo names)+
in repo names) (for bazel 8)
Thanks for the contribution! I agree with the goal, but unfortunately the update seems to be failing on CI... I pushed a couple of commits trying to fix things, but no joy! If you can get things green, I'm happy to merge! |
56acae0
to
4c2b408
Compare
Thanks. I think I'm pretty close now (one test failure left). I'll let you know here once I'm ready for a review. |
Tests are passing now @illicitonion. It took some time to debug a strange regression (I think) caused by bazel-contrib/bazel-gazelle#1911 (mainly in I know the work-around isn't the cleanest but it's all that I have time to do right now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for persisting through this! Just one small change to think about/do and let's get this merged!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This is required for bazel 8 compatibility.
Currently hitting
failed to parse cquery result: label parse error: repository has invalid characters: "@@rules_python++python+python_3_11_x86_64-unknown-linux-gnu//:python_runtimes"
.This should be fixed by bazel-contrib/bazel-gazelle#1856.