feat: Transition oci_image_index into a macro with additional [name].digest target #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesayyn
approved these changes
Dec 12, 2024
alexeagle
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue #735.
Since
oci_image_indexwas a rule directly exposed indefs.bzl, I had to introduce a new macro. I opted to make it in the same way asoci_index, by using theoci_index_imagename for the macro, while renaming the existing rule asoci_index_image_rule. I'm not sure if this kind of change would be considered a breaking change or not.Please review if you find this kind of change from a rule to a macro acceptable or not. If not, I can expose this new macro with a different name (if you have any suggestions on what name to use, I'm all ears 😅) keeping the old rule unchanged.