Fix import to include full path #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acozzette
requested review from
asraa,
inferno-chromium,
fniksic,
oliverchang,
stefanbucur and
xinhaoyuan
as code owners
|
Happy to accept this, but I see some regression failures. Do you have a sense what might be going on there? |
|
This could very well be a regression caused by updates to the macOS runner. Probably worth trying to update rules_python to the latest version. |
This seems to be necessary for the project to build successfully with Bazel 6. I also fixed some build errors related to Python 3.12, by upgrading to the most recent versions of absl, six, and rules_python.
acozzette
force-pushed
the
upgrade-bazel
branch
from
8984d12 to
7172ffd
Compare
|
I just pushed a few more fixes that should hopefully address the failure. I think @fmeum is right and this was caused by the MacOS runners recently upgrading to Python 3.12. We hit the same problem in protobuf recently. I am going to be out for the next four weeks starting on Monday, so if this ends up not being mergeable as is then someone else may want to take over. |
stefanbucur
approved these changes
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be necessary for the project to build successfully with Bazel 6.
I also fixed some build errors related to Python 3.12, by upgrading to the most recent versions of absl, six, and rules_python.