Revert "feat: allow BCR maintainers to modify pull request" #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 354ba4e.
cgrindel
approved these changes
Nov 28, 2023
|
fyi @meteorcloudy |
|
Ah, I see. Thanks for the trying this out. I guess this isn't a super urgent feature anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 354ba4e.
Recall there are actually two GitHub apps: one that users install to their ruleset/fork, and one that Google installs on the BCR for opening pull requests. The second app doesn't have repository write permissions so Google is more comfortable installing it to the BCR.
Testing this in my dev environment, it fails because the second GitHub app, which opens up the pull request, doesn't have permissions to the fork it's pr'ing from, so it can't enable this option. To solve this, I think we would need to ask users to install both apps (worse DX) or use one app with elevated permissions (Google doesn't like).