Retry on HTTP 404

src/domain/release-archive.spec.ts

@@ -76,6 +76,11 @@ describe("fetch", () => {
 
     expect(axiosRetry).toHaveBeenCalledWith(axios, {
       retries: 3,
+      retryCondition: expect.matchesPredicate((retryConditionFn: Function) => {
+        // Make sure HTTP 404 errors are retried.
+        let notFoundError = { response: { status: 404 } };
+        return retryConditionFn.call(this, notFoundError);
+      }),
       retryDelay: expect.matchesPredicate((retryDelayFn: Function) => {
         // Make sure the retry delays follow exponential backoff
         // and the final retry happens after at least 1 minute total

src/domain/release-archive.ts

@@ -117,6 +117,14 @@ function exponentialDelay(
   return axiosRetry.exponentialDelay(retryCount, error, delayFactor);
 }
 
+function defaultRetryPlus404(error: AxiosError): boolean {
+  // Publish-to-BCR needs to support retrying when GitHub returns 404
+  // in order to support automated release workflows that upload artifacts
+  // within a minute or so of publishing a release.
+  // Apart from this case, use the default retry condition.
+  return error.response.status === 404 || axiosRetry.isNetworkOrIdempotentRequestError(error);
+}
+
 async function download(url: string, dest: string): Promise<void> {
   if (process.env.INTEGRATION_TESTING) {
     // Point downloads to the standin github server
@@ -140,6 +148,7 @@ async function download(url: string, dest: string): Promise<void> {
     retries: 3,
     retryDelay: exponentialDelay,
     shouldResetTimeout: true,
+    retryCondition: defaultRetryPlus404,
   });
 
   let response: AxiosResponse;