Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support newer mypy versions #72

Merged
merged 2 commits into from
Jan 11, 2023
Merged

Conversation

caseyduquettesc
Copy link
Contributor

Fixes #70

Last version of mypy/main.py that allowed positional arguments:
https://github.com/python/mypy/blob/v0.971/mypy/main.py

Keyword arguments are required from 0.981 onwards (circle September 8, 2022):
https://github.com/python/mypy/blob/v0.981/mypy/main.py

@caseyduquettesc
Copy link
Contributor Author

@alexeagle @thundergolfer PTAL? Not sure what the process is on requesting reviews. Apologies for the direct mention.

Copy link
Collaborator

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry I missed the notifications on this. Looks pretty safe to me, even though we don't have tests for it.

@alexeagle alexeagle merged commit c82a2d5 into bazel-contrib:main Jan 11, 2023
@alexeagle
Copy link
Collaborator

Somehow this PR did make CI go red on main, someone will have to look more when we have some funding to spend time on it.

@beeftornado
Copy link

Error looks the same as the one mentioned in #69

@adzenith adzenith mentioned this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mypy/main.py requires kwargs from 0.981 onwards (circa September 8, 2022):
3 participants