Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geometry functions now works with top window #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

geometry functions now works with top window #8

wants to merge 1 commit into from

Conversation

paul-axe
Copy link
Contributor

@paul-axe paul-axe commented Nov 4, 2015

Now it resolves top-level window (with wm decorations) to obtain/change geometry. Not sure if cycle condition is reliable, but can't find any bugs here

@paul-axe
Copy link
Contributor Author

paul-axe commented Nov 4, 2015

Btw, i think to forget to add to commit one thing. Not sure how it should work, but moveresize must not to consider viewport size, because get_window_geometry doesn't. Now if we'll try to get window coordinates and then use them in moveresize, window will moved. The diff is

-        o_x, o_y, _, _ = tuple(self.get_workarea())
-        params = flags, x+o_x, y+o_y, max(1, w), max(1, h)
+        params = flags, x, y, max(1, w), max(1, h)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant