feat: conditional rendering of the hero ++ dynamic routing of the doc…

… page
batleforc · Aug 24, 2024 · dd7063f · dd7063f
1 parent 75e8bb0
commit dd7063f
Show file tree

Hide file tree

Showing 8 changed files with 45 additions and 11 deletions.
diff --git a/apps/front/src/router/index.ts b/apps/front/src/router/index.ts
@@ -8,11 +8,24 @@ const router = createRouter({
       path: '/',
       name: 'home',
       component: HomeView,
+      meta: {
+        hero: true,
+      },
     },
     {
       path: '/doc',
-      name: 'doc',
-      component: () => import('../views/DocView.vue'),
+      children: [
+        {
+          name: 'doc',
+          path: '',
+          component: () => import('../views/DocHomeView.vue'),
+        },
+        {
+          name: 'doccontent',
+          path: ':page+',
+          component: () => import('../views/DocView.vue'),
+        },
+      ],
     },
     {
       path: '/blog',

diff --git a/apps/front/src/views/App.vue b/apps/front/src/views/App.vue
@@ -11,7 +11,7 @@ if (!indexStore.inited && !indexStore.homeLoading) {
 </script>
 
 <template>
-  <Hero />
+  <Hero v-if="$route.meta.hero" />
   <NavBar v-if="indexStore.inited" :link="indexStore.homeContent.url" />
   <RouterView />
 </template>
diff --git a/apps/front/src/views/BlogHomeView.vue b/apps/front/src/views/BlogHomeView.vue
@@ -0,0 +1,9 @@
+<script setup lang="ts">
+
+</script>
+
+<template>
+    <div id="title" class="container">
+        <h1>Blog home page</h1>
+    </div>
+</template>
diff --git a/apps/front/src/views/BlogView.vue b/apps/front/src/views/BlogView.vue
@@ -4,6 +4,6 @@
 
 <template>
     <div id="title" class="container">
-        <h1>Blog home page</h1>
+        <h1>Blog sub page</h1>
     </div>
 </template>
diff --git a/apps/front/src/views/DocHomeView.vue b/apps/front/src/views/DocHomeView.vue
@@ -0,0 +1,9 @@
+<script setup lang="ts">
+
+</script>
+
+<template>
+    <div id="title" class="container">
+        <h1>Doc home page</h1>
+    </div>
+</template>
diff --git a/apps/front/src/views/DocView.vue b/apps/front/src/views/DocView.vue
@@ -4,6 +4,7 @@
 
 <template>
     <div id="title" class="container">
-        <h1>Doc home page</h1>
+        <h1>Doc sub page</h1>
+        <p>{{ $route.params.page }}</p>
     </div>
 </template>
diff --git a/apps/front/src/views/HomeView.vue b/apps/front/src/views/HomeView.vue
@@ -43,7 +43,9 @@ const { type } = useBreakpoints();
             </Timeline>
         </div>
         <Panel class="" header="Pour aller plus loin">
-            <p>Maintenant que vous avez un peu plus d'informations sur moi, que diriez-vous de découvrir la suite ?</p>
+            <p>Maintenant que vous avez un peu plus d'informations sur mon historique, que diriez-vous de découvrir la
+                suite ?
+            </p>
             <div class="flex justify-around flex-wrap">
                 <RouterLink to="doc">
                     <Card class="homePageGoFurtherCard">

diff --git a/cicd/Readme.md b/cicd/Readme.md
@@ -22,7 +22,7 @@
 
 - Run Code Coverage tests on the Backend
 - Run E2E tests on the Frontend
-- Run Lighthouse tests on the Frontend
+- Run Lighthouse tests on the Frontend/backend <https://github.com/jenkins-x/lighthouse/blob/main/docs/install_lighthouse_with_tekton.md>
 - Run Security tests on both the Backend and the Frontend
 
 ### Deployment flow
@@ -60,21 +60,21 @@ flowchart TD;
 
 ## Tasks
 
-- [ ] Update Github with pipeline status <https://hub.tekton.dev/tekton/task/github-set-status>
+- [x] Update Github with pipeline status <https://hub.tekton.dev/tekton/task/github-set-status>
 - [ ] Generate a Software Bill of Materials (SBOM) <https://hub.tekton.dev/tekton/task/syft>
 - [ ] Analyze the SBOM for vulnerabilities <https://hub.tekton.dev/tekton/task/grype>
 - [ ] Send a notification to discord <https://hub.tekton.dev/tekton/task/send-to-webhook-discord>
   - When a PR pass the test flow
   - When a PR is merged
   - When a new version is deployed (beta or production)
   - When a vulnerability is found (don't know if it's possible to send the vulnerability from github to discord)
-- [ ] Create a Helm chart for the backend/frontend
-- [ ] Build the Frontend/Backend
+- [x] Create a Helm chart for the backend/frontend
+- [x] Build the Frontend/Backend
 - [ ] Check if the Frontend/Backend helm chart is Okay <https://hub.tekton.dev/tekton/task/pluto>
 - [ ] Check secret <https://hub.tekton.dev/tekton/task/kube-linter>
 
 ## Github Events to listen
 
 - [ ] Pull Request "opened, synchronized"
-- [ ] Push on the `main` branch
+- [x] Push on the `main` branch
 - [ ] Tag created