Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty message #66

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Allow empty message #66

merged 1 commit into from
Mar 4, 2024

Conversation

tlebreton
Copy link

Hello

Since the last version we can't publish empty string or null as a payload we will get the following error :

Message: Typed property Basis\Nats\Message\Msg::$payload must not be accessed before initialization
File: /opt/project/BACKEND/vendor/basis-company/nats/src/Client.php
Line: 344
Trace: #0 /opt/project/BACKEND/vendor/basis-company/nats/src/Client.php(323): Basis\Nats\Client->onMessage(Object(Basis\Nats\Message\Msg), true)

Thanks for the work for this library :)

@ro0NL
Copy link
Contributor

ro0NL commented Feb 26, 2024

ref #64

@nekufa
Copy link
Member

nekufa commented Mar 4, 2024

hi @tlebreton, sorry for delay, was on a vacation :) thanks for the fix!

@nekufa nekufa merged commit 2a8072a into basis-company:main Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants