remove react as peers; replace Date.now() with performance.now() in p…

…rep to nextjs dynamic io
basehub-ai · Oct 24, 2024 · 9982eb3 · 9982eb3
1 parent 3219480
commit 9982eb3
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 10 deletions.
diff --git a/packages/basehub/package.json b/packages/basehub/package.json
@@ -46,10 +46,6 @@
     "build:bin": "pnpm emit-dts && tsup --config tsup-bin.config.ts",
     "build:client": "tsup --config tsup-client.config.ts"
   },
-  "peerDependencies": {
-    "react": "^18.2.0",
-    "react-dom": "^18.2.0"
-  },
   "dependencies": {
     "@basehub/genql": "9.0.0-canary.5",
     "@basehub/mutation-api-helpers": "2.0.2",

diff --git a/packages/basehub/src/react/pump/client-pump.tsx b/packages/basehub/src/react/pump/client-pump.tsx
@@ -27,7 +27,7 @@ const clientCache = new Map<
 
 const lastResponseHashCache = new Map<string, string>();
 
-const DEDUPE_TIME_MS = 500;
+const DEDUPE_TIME_MS = 32;
 
 export const ClientPump = <Queries extends PumpQuery[]>({
   children,
@@ -87,7 +87,7 @@ export const ClientPump = <Queries extends PumpQuery[]>({
 
         if (clientCache.has(queryCacheKey)) {
           const cached = clientCache.get(queryCacheKey)!;
-          if (Date.now() - cached.start < DEDUPE_TIME_MS) {
+          if (performance.now() - cached.start < DEDUPE_TIME_MS) {
             const response = await cached.response;
             if (!response) return null;
             if (response.newPumpToken) {
@@ -144,7 +144,7 @@ export const ClientPump = <Queries extends PumpQuery[]>({
 
         // we quickly set the cache (without awaiting)
         clientCache.set(queryCacheKey, {
-          start: Date.now(),
+          start: performance.now(),
           response: responsePromise,
         });
 

diff --git a/packages/basehub/src/react/pump/server-pump.tsx b/packages/basehub/src/react/pump/server-pump.tsx
@@ -34,7 +34,7 @@ let pumpToken: string | null = null;
 let spaceID: string | null = null;
 let pusherData: ResponseCache["pusherData"] | null = null;
 
-const DEDUPE_TIME_MS = 500;
+const DEDUPE_TIME_MS = 32;
 
 export type PumpProps<Queries extends Array<PumpQuery>> = {
   children: (
@@ -98,7 +98,7 @@ export const Pump = async <Queries extends Array<PumpQuery>>({
 
       if (cache.has(cacheKey)) {
         const cached = cache.get(cacheKey)!;
-        if (Date.now() - cached.start < DEDUPE_TIME_MS) {
+        if (performance.now() - cached.start < DEDUPE_TIME_MS) {
           data = (await cached.data) as any;
         }
       }
@@ -134,7 +134,7 @@ export const Pump = async <Queries extends Array<PumpQuery>>({
             })
           : basehub(basehubProps).query(singleQuery);
         cache.set(cacheKey, {
-          start: Date.now(),
+          start: performance.now(),
           data: dataPromise,
         });
         data = await dataPromise;