This repository has been archived by the owner on Mar 2, 2020. It is now read-only.
Wrapping mail generation in rolled-back transaction to prevent database changes from persisting #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…database changes from persisting during the former
|
Will you guys ever integrate this in ActionMailer? It's pretty useful |
| ActiveRecord::Base.transaction do | ||
| mail = send(name) | ||
| raise ActiveRecord::Rollback | ||
| end | ||
| Mail.inform_interceptors(mail) if defined? Mail |
There was a problem hiding this comment.
This would need to be within the transaction, before rollback.
|
It's a nice idea. It's simple in the common case, but breaks down at the edges. Considering that seed data handles these cases nicely, or using |
costa
added a commit
to costa/mail_view
that referenced
this pull request
Oct 2, 2014
|
@jeremy Seed data? Using any other form of protection is great, but less convenient, that's the point of this discussion. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use factories for specs and I find them very convenient to use in mail_view's "actions".
Factories — as well as other methods for generating sample data on the fly — need to be cleaned after.
Since mail_view is supposed to be read-only, I see no disadvantage in actual prevention of data changes persistency — using transactions.
The first commit is kinda working draft for discussion, I'll add specs+docs if needed.
p.s. I've seen #69 but did neither like the solution nor understand the discussion there.
slightly-off-topic: Might be useful to include in the docs: mail_view for human — and also for automatic — testing.