Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) - Update Pyth Oracle #798

Merged
merged 35 commits into from
Oct 18, 2024
Merged

(feat) - Update Pyth Oracle #798

merged 35 commits into from
Oct 18, 2024

Conversation

aditya520
Copy link
Contributor

What changed? Why?
Updated Pyth Oracle info.

Notes to reviewers

How has it been tested?

Copy link

vercel bot commented Aug 7, 2024

@aditya520 is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Aug 7, 2024

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Copy link

vercel bot commented Aug 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
base-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 9:59pm
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 9:59pm

Copy link

vercel bot commented Aug 27, 2024

Deployment failed with the following error:

The provided GitHub repository does not contain the requested branch or commit reference. Please ensure the repository is not empty.

Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@cb-heimdall
Copy link
Collaborator

Review Error for wbnns @ 2024-10-17 07:49:09 UTC
User cannot review their own commit

@brendan-defi
Copy link
Collaborator

@aditya520 this is failing our CI. Could you see if you can figure out what's up? Let me know if you're not able to determine / fix the issue.

Thanks!

@aditya520
Copy link
Contributor Author

@brendan-defi Can you check again? I think it should work now.

@wbnns wbnns added state: in progress change(s) requested One or more changes have been requested labels Oct 18, 2024
@brendan-defi brendan-defi merged commit e3bbd75 into base-org:master Oct 18, 2024
4 of 5 checks passed
@brendan-defi
Copy link
Collaborator

thanks @aditya520! approved and merging now

kirkas pushed a commit that referenced this pull request Oct 21, 2024
* (feat) - Update Pyth Oracle

* edits

* requested changes

* requested changes

* requested changes

* requested changes

* fix

---------

Co-authored-by: wbnns <[email protected]>
Co-authored-by: Brendan from DeFi <[email protected]>
kirkas pushed a commit that referenced this pull request Oct 21, 2024
* (feat) - Update Pyth Oracle

* edits

* requested changes

* requested changes

* requested changes

* requested changes

* fix

---------

Co-authored-by: wbnns <[email protected]>
Co-authored-by: Brendan from DeFi <[email protected]>
chrischang pushed a commit to chrischang/web that referenced this pull request Jan 15, 2025
* (feat) - Update Pyth Oracle

* edits

* requested changes

* requested changes

* requested changes

* requested changes

* fix

---------

Co-authored-by: wbnns <[email protected]>
Co-authored-by: Brendan from DeFi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change(s) requested One or more changes have been requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants