Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(hardhat): Clarify API key is required #1558

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Conversation

wbnns
Copy link
Member

@wbnns wbnns commented Jan 13, 2025

What changed? Why?

Basescan now requires an API key to verify contracts on Base Sepolia; this change updates to clarify where to get one

Notes to reviewers

N/A

How has it been tested?

Localhost

@wbnns wbnns added the base docs review To be reviewed by the Base docs team label Jan 13, 2025
Copy link

vercel bot commented Jan 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
base-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 8:53pm
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 8:53pm

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jan 13, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@cb-heimdall
Copy link
Collaborator

Review Error for hughescoin @ 2025-01-14 23:44:20 UTC
User failed mfa authentication, see go/mfa-help

@wbnns wbnns enabled auto-merge (squash) January 14, 2025 23:46
@hughescoin hughescoin self-requested a review January 15, 2025 01:36
@wbnns wbnns merged commit 2146691 into master Jan 15, 2025
9 checks passed
@wbnns wbnns deleted the wbnns/basescan-key branch January 15, 2025 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base docs review To be reviewed by the Base docs team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants