Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance PaymentReceiver contract security and transparency #1538

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

crStiv
Copy link
Contributor

@crStiv crStiv commented Jan 6, 2025

  • Added owner access control to withdrawEther function
  • Implemented safe ETH transfer pattern using call()
  • Added EtherWithdrawn event for better transaction tracking
  • Added balance checks before withdrawal
  • Made owner variable public for transparency

Copy link

vercel bot commented Jan 6, 2025

@crStiv is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@cb-heimdall
Copy link
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Copy link

vercel bot commented Jan 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 6, 2025 0:22am

@wbnns
Copy link
Member

wbnns commented Jan 15, 2025

@crStiv

Thanks for contributing! Adding this to our backlog, pending to be reviewed. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base docs review To be reviewed by the Base docs team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants