Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typos and improved clarity in documentation #1474

Merged
merged 5 commits into from
Dec 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/base-docs/docs/tokens/token-list.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ hide_table_of_contents: true

This page is intended for token issuers who already have an ERC-20 contract deployed on Ethereum and would like to submit their token for bridging between Ethereum and Base. Base uses the [Superchain token list](https://github.com/ethereum-optimism/ethereum-optimism.github.io) as a reference for tokens that have been deployed on Base.

**_Disclaimer: Base does not endorse any of the tokens that are listed in the Github repository and has conducted only preliminary checks, which include automated checks listed_** [**_here_**](https://github.com/ethereum-optimism/ethereum-optimism.github.io)**_._**
**_Disclaimer: Base does not endorse any of the tokens that are listed in the GitHub repository and has conducted only preliminary checks, which include automated checks listed_** [**_here_**](https://github.com/ethereum-optimism/ethereum-optimism.github.io)**_._**

---

Expand All @@ -41,4 +41,4 @@ Follow the instructions in the [GitHub repository](https://github.com/ethereum-o

### Step 3: Await final approval

Reviews are regularly conducted by the Base team and you should receive a reply within 24-72 hours (depending on if the PR is opened on a week day, weekend or holiday).
Reviews are regularly conducted by the Base team and you should receive a reply within 24-72 hours (depending on if the PR is opened on a weekday, weekend or holiday).
2 changes: 1 addition & 1 deletion apps/bridge/src/data/useWithdrawals.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ async function fetchOPWithdrawals(address: string) {

async function fetchExplorerWithdrawals(address: string, isMainnet: boolean) {
const response = await getJSON<BlockExplorerApiResponse<BlockExplorerTransaction[]>>(
// TODO: filter to transactions to the withdraw contract
// TODO: filter transactions to the withdraw contract
publicRuntimeConfig.l2ExplorerApiURL,
{
address,
Expand Down
2 changes: 1 addition & 1 deletion apps/web/app/AppProviders.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ type AppProvidersProps = {
children: React.ReactNode;
};

// TODO: Not all pages needs all these components, ideally should be split and put
// TODO: Not all pages need all these components, ideally should be split and put
// on the sub-layouts
export default function AppProviders({ children }: AppProvidersProps) {
const trackingPreference = useRef<TrackingPreference | undefined>();
Expand Down
2 changes: 1 addition & 1 deletion apps/web/contexts/Analytics.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export const AnalyticsContext = createContext<AnalyticsContextProps>({
export function useAnalytics() {
const context = useContext(AnalyticsContext);
if (context === undefined) {
throw new Error('useAnalytics must be used within a AnalyticsProvider');
throw new Error('useAnalytics must be used within an AnalyticsProvider');
}
return context;
}
Expand Down
2 changes: 1 addition & 1 deletion apps/web/pages/api/proofs/coinbase/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export type CoinbaseProofResponse = {
};

/**
* This endpoint reports whether or not the provided access has access to the verified account attestation
* This endpoint reports whether or not the provided address has access to the verified account attestation
*
* Error responses:
* 400: if address is invalid or missing verifications
Expand Down
Loading