Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add Russian and Ukrainian translation of "Base is for everyone" on the homepage #1438

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

anim001k
Copy link
Contributor

What changed? Why?
Adding Russian and Ukrainian to the Base is for everyone slider on the homepage

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Dec 20, 2024

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Copy link

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 24, 2024 10:22am

Copy link

vercel bot commented Dec 20, 2024

@anim001k is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@anim001k
Copy link
Contributor Author

@wbnns #1425 reopened.

@wbnns wbnns added base web review To be reviewed by the Base web team base translation review To be reviewed by the Base translation team and removed base web review To be reviewed by the Base web team labels Dec 21, 2024
@anim001k
Copy link
Contributor Author

Hi, @wbnns! Is there something I can improve?

@wbnns wbnns added the question A question is awaiting an answer label Dec 30, 2024
@wbnns
Copy link
Member

wbnns commented Dec 30, 2024

@anim001k Thank you for checking in. It seems the Russian translation does not translate to "Base is for everyone", is that correct?

@anim001k
Copy link
Contributor Author

@wbnns Yes, I am a native speaker of Russian and Ukrainian, so I can assure you that this is the correct translation. I would like to point out that the translator makes a mistake by translating Base as база, whereas the correct version is бейз

@anim001k
Copy link
Contributor Author

@wbnns Can I help in any way?

Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anim001k Thanks for the info and for contributing to build on Base 🔵

@wbnns wbnns removed the question A question is awaiting an answer label Jan 15, 2025
@wbnns wbnns enabled auto-merge (squash) January 15, 2025 00:20
@wbnns wbnns merged commit dc239b8 into base-org:master Jan 15, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base translation review To be reviewed by the Base translation team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants