Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix video rendering on some iOS devices by switching to mp4 #1421

Merged
merged 5 commits into from
Dec 19, 2024

Conversation

dschlabach
Copy link
Contributor

@dschlabach dschlabach commented Dec 19, 2024

What changed? Why?
We had an issue where some webm files were not loading on certain iOS devices (not all, and seemingly not dependent on iOS version).

After testing, I was able to figure out that our webm files were encoded codec_name=vp9; when I converted this to VP8, it was supported on iOS simulators and in other browsers. The issue with VP8 files that I generated was that they were far too big in size [reference].

My next approach was to use a mp4 file with a poster attribute, but this sometimes causes a flicker once the user tries to play the video and it transitions from the poster to the video.

Finally, I've settled on using mp4s, which are not much bigger than the original webm files, and setting the timestamp to 0.001 in lieu of using a poster attribute.

Notes to reviewers

How has it been tested?

Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
base-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 1:21am
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 1:21am

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Dec 19, 2024

✅ Heimdall Review Status

Requirement Status More Info
Reviews 2/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@dschlabach dschlabach merged commit 9dfcbbb into master Dec 19, 2024
9 checks passed
@dschlabach dschlabach deleted the dms/mp4 branch December 19, 2024 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants