-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Portuguese 🇵🇹🇧🇷 - “Base é para todos” #1288
base: master
Are you sure you want to change the base?
Conversation
Adding the Portuguese version of “Base is for everyone”: “Base é para todos” LFB! 💙
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@supermari0x is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
🟡 Heimdall Review Status
|
Bom dia, Mario! Could you please resolve the merge conflict? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested an additional change in-line 🙏
apps/web/src/components/base-org/root/SlidingTextSection/index.tsx
Outdated
Show resolved
Hide resolved
const text = ' Base is for everyone - بایس للجمیع - Base es para todos - 基地适合所有人 - La Base è per tutti - Base est pour tout le monde - Base ni ya kila mtu - Base yɛ ma obiara - Base nye amesiame tɔ - Base ji he ni mɔ fɛɛ mɔ yɔɔ - '; | ||
|
||
|
||
const text = ' Base is for everyone - بایس للجمیع - Base es para todos - 基地适合所有人 - La Base è per tutti - Base est pour tout le monde - Base ni ya kila mtu - Base yɛ ma obiara - Base nye amesiame tɔ - Base ji he ni mɔ fɛɛ mɔ yɔɔ - Base é para todos -'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be a space after -
and before '
at the end of the line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done ✅
@supermari0x Left an additional request for change in-line and there is also a merge conflict 🙏 |
@wbnns fixed ✅ |
What changed? Why?
Adding the Portuguese version of “Base is for everyone”: “Base é para todos” LFB! 💙
Notes to reviewers
How has it been tested?
Ran yarn workspace @app/web dev
Navigated to http://localhost:3000 in my browser
Slider is working as expected