Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Portuguese 🇵🇹🇧🇷 - “Base é para todos” #1288

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

supermari0x
Copy link

What changed? Why?
Adding the Portuguese version of “Base is for everyone”: “Base é para todos” LFB! 💙

Notes to reviewers

How has it been tested?
Ran yarn workspace @app/web dev
Navigated to http://localhost:3000 in my browser
Slider is working as expected

Adding the Portuguese version of “Base is for everyone”: “Base é para todos”
LFB! 💙
Copy link

vercel bot commented Nov 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
base-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 0:38am
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 0:38am

Copy link

vercel bot commented Nov 23, 2024

@supermari0x is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Nov 23, 2024

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 -1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@wbnns
Copy link
Member

wbnns commented Dec 6, 2024

@supermari0x

Bom dia, Mario! Could you please resolve the merge conflict?

@wbnns wbnns added change(s) requested One or more changes have been requested community contribution labels Dec 6, 2024
Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@supermari0x

Requested an additional change in-line 🙏

@wbnns wbnns added base web review To be reviewed by the Base web team base translation review To be reviewed by the Base translation team and removed base web review To be reviewed by the Base web team labels Dec 19, 2024
const text = ' Base is for everyone - بایس للجمیع - Base es para todos - 基地适合所有人 - La Base è per tutti - Base est pour tout le monde - Base ni ya kila mtu - Base yɛ ma obiara - Base nye amesiame tɔ - Base ji he ni mɔ fɛɛ mɔ yɔɔ - ';


const text = ' Base is for everyone - بایس للجمیع - Base es para todos - 基地适合所有人 - La Base è per tutti - Base est pour tout le monde - Base ni ya kila mtu - Base yɛ ma obiara - Base nye amesiame tɔ - Base ji he ni mɔ fɛɛ mɔ yɔɔ - Base é para todos -';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a space after - and before ' at the end of the line

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done ✅

@wbnns
Copy link
Member

wbnns commented Jan 14, 2025

@supermari0x Left an additional request for change in-line and there is also a merge conflict 🙏

@supermari0x
Copy link
Author

@wbnns fixed ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base translation review To be reviewed by the Base translation team change(s) requested One or more changes have been requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants