Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tutorial] Add Paymaster + Wagmi tutorial and remove large .gif for OCK theme tutorial #1188

Closed
wants to merge 16 commits into from
Closed

[Tutorial] Add Paymaster + Wagmi tutorial and remove large .gif for OCK theme tutorial #1188

wants to merge 16 commits into from

Conversation

hughescoin
Copy link
Collaborator

What changed? Why?

  • Add new tutorial for Paymaster integration for Wagmi apps
  • Update links in OCK Fund tutorial
  • Remove large .gif file from OCK Theme tutorial

Notes to reviewers

How has it been tested?
yes

@vercel Vercel
Copy link

vercel bot commented Nov 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
base-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 9:37pm
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 9:37pm

@vercel Vercel
Copy link

vercel bot commented Nov 1, 2024

@hughescoin is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Nov 1, 2024 •
edited
Loading

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@hughescoin hughescoin enabled auto-merge (squash) November 1, 2024 20:22
ericbrown99
ericbrown99 reviewed Nov 1, 2024
View reviewed changes
Copy link
Contributor

@ericbrown99 ericbrown99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted a couple typos, otherwise looks good!

wbnns
wbnns previously requested changes Nov 2, 2024
View reviewed changes
Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hughescoin

Heya, looks like this still brings in the large gif; can you please remove?

2024-11-02 at 13 52 51@2x

@wbnns wbnns added the change(s) requested One or more changes have been requested label Nov 2, 2024
@wbnns wbnns self-assigned this Nov 2, 2024
@hughescoin hughescoin dismissed wbnns’s stale review November 4, 2024 18:34

Removed the .gif

@cb-heimdall
Copy link
Collaborator

Review Error for ericbrown99 @ 2024-11-04 18:37:55 UTC
User failed mfa authentication, see go/mfa-help

@hughescoin hughescoin requested a review from wbnns November 5, 2024 03:34
@hughescoin hughescoin closed this by deleting the head repository Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericbrown99 ericbrown99 ericbrown99 approved these changes

@0xAlec 0xAlec Awaiting requested review from 0xAlec

@wbnns wbnns Awaiting requested review from wbnns

Assignees

@wbnns wbnns

Labels
change(s) requested One or more changes have been requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hughescoin @cb-heimdall @wbnns @ericbrown99