Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve readability of the frame error wrapper #1090

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

JFrankfurt
Copy link
Contributor

This adds some comments and a better name to the higher order function handling frame error discrimination per @kirkas 's suggestion

@JFrankfurt JFrankfurt requested a review from kirkas October 17, 2024 15:24
@JFrankfurt JFrankfurt self-assigned this Oct 17, 2024
Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
base-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 3:30pm
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 3:30pm

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Oct 17, 2024

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@JFrankfurt JFrankfurt enabled auto-merge (squash) October 17, 2024 15:26
@JFrankfurt JFrankfurt merged commit 1a72bac into master Oct 17, 2024
8 checks passed
@JFrankfurt JFrankfurt deleted the improve-fn-readability branch October 17, 2024 15:33
kirkas pushed a commit that referenced this pull request Oct 21, 2024
kirkas pushed a commit that referenced this pull request Oct 21, 2024
chrischang pushed a commit to chrischang/web that referenced this pull request Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants