Fix: use capabilities instead of connector.id for feature detection #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Heimdall Review Status
|
zencephalon
approved these changes
Oct 14, 2024
JFrankfurt
reviewed
Oct 14, 2024
| chain: Chain; | ||
| }; | ||
|
|
||
| export default function useCapabilitiesSafe({ chain }: UseCapabilitiesSafeProps) { |
There was a problem hiding this comment.
can you add a comment about what makes this "safe"?
There was a problem hiding this comment.
(as opposed to some other mechanism of checking that wouldn't be safe)
There was a problem hiding this comment.
it's in the comment above !
kirkas
added a commit
that referenced
this pull request
Oct 21, 2024
kirkas
added a commit
that referenced
this pull request
Oct 21, 2024
chrischang
pushed a commit
to chrischang/web
that referenced
this pull request
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.