Skip to content

Commit

Permalink
Resolve type errors?
Browse files Browse the repository at this point in the history
  • Loading branch information
zencephalon committed Nov 6, 2024
1 parent fa1441e commit 9e11588
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 10 deletions.
10 changes: 5 additions & 5 deletions apps/web/src/components/Basenames/ManageNames/NameDisplay.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import UsernameProfileProvider from 'apps/web/src/components/Basenames/UsernameP
import ProfileTransferOwnershipProvider from 'apps/web/src/components/Basenames/UsernameProfileTransferOwnershipModal/context';
import UsernameProfileTransferOwnershipModal from 'apps/web/src/components/Basenames/UsernameProfileTransferOwnershipModal';
import BasenameAvatar from 'apps/web/src/components/Basenames/BasenameAvatar';
import { BaseName } from '@coinbase/onchainkit/identity';
import { Basename } from '@coinbase/onchainkit/identity';
import { formatDistanceToNow, parseISO } from 'date-fns';
import { Icon } from 'apps/web/src/components/Icon/Icon';
import Dropdown from 'apps/web/src/components/Dropdown';
Expand Down Expand Up @@ -44,21 +44,21 @@ type NameDisplayProps = {
export default function NameDisplay({ domain, isPrimary, tokenId, expiresAt }: NameDisplayProps) {
const expirationText = formatDistanceToNow(parseISO(expiresAt), { addSuffix: true });

const { setPrimaryUsername } = useUpdatePrimaryName(domain as BaseName);
const { setPrimaryUsername } = useUpdatePrimaryName(domain as Basename);

const [isOpen, setIsOpen] = useState<boolean>(false);
const openModal = useCallback(() => setIsOpen(true), []);
const closeModal = useCallback(() => setIsOpen(false), []);

const { removeNameFromUI } = useRemoveNameFromUI(domain as BaseName);
const { removeNameFromUI } = useRemoveNameFromUI(domain as Basename);

return (
<li key={tokenId} className={pillNameClasses}>
<div className="flex items-center justify-between">
<Link href={`/name/${domain.split('.')[0]}`}>
<div className="flex items-center gap-4">
<BasenameAvatar
basename={domain as BaseName}
basename={domain as Basename}
wrapperClassName={avatarClasses}
width={4 * 16}
height={4 * 16}
Expand Down Expand Up @@ -96,7 +96,7 @@ export default function NameDisplay({ domain, isPrimary, tokenId, expiresAt }: N
</Dropdown>
</div>
</div>
<UsernameProfileProvider username={domain as BaseName}>
<UsernameProfileProvider username={domain as Basename}>
<ProfileTransferOwnershipProvider>
<UsernameProfileTransferOwnershipModal
isOpen={isOpen}
Expand Down
3 changes: 2 additions & 1 deletion apps/web/src/components/Basenames/ManageNames/NamesList.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ function NamesLayout({ children }: { children: React.ReactNode }) {
return (
<div className="mx-auto max-w-2xl space-y-4 p-8">
<div className="flex items-center justify-between">
<h1 className="text-3xl font-bold">My Basenames</h1>
<h1 className="mb-4 text-3xl font-bold">My Basenames</h1>
<Link
className="rounded-lg bg-palette-backgroundAlternate p-2 text-sm text-palette-foreground"
href="/names/"
Expand Down Expand Up @@ -38,6 +38,7 @@ export default function NamesList() {
<NamesLayout>
<div>
No names found.
<br />
<Link href="/names/">Get a Basename!</Link>
</div>
</NamesLayout>
Expand Down
2 changes: 1 addition & 1 deletion apps/web/src/components/Basenames/ManageNames/hooks.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ export function useUpdatePrimaryName(domain: BaseName) {
// Hook to update primary name
const { setPrimaryName } = useSetPrimaryBasename({
secondaryUsername: domain,
});
}) as { setPrimaryName: () => Promise<void> };

const setPrimaryUsername = useCallback(() => {
setPrimaryName()
Expand Down
7 changes: 4 additions & 3 deletions apps/web/src/hooks/useSetPrimaryBasename.ts
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,12 @@ export default function useSetPrimaryBasename({ secondaryUsername }: UseSetPrima
}
}, [logError, refetchPrimaryUsername, transactionIsSuccess]);

const setPrimaryName = useCallback(async () => {
const setPrimaryName = useCallback(async (): Promise<boolean | undefined> => {
// Already primary
if (secondaryUsername === primaryUsername) return;
if (secondaryUsername === primaryUsername) return undefined;

// No user is connected
if (!address) return;
if (!address) return undefined;

try {
await initiateTransaction({
Expand All @@ -81,6 +81,7 @@ export default function useSetPrimaryBasename({ secondaryUsername }: UseSetPrima
});
} catch (error) {
logError(error, 'Set primary name transaction canceled');
return undefined;
}

return true;
Expand Down

0 comments on commit 9e11588

Please sign in to comment.