Add getL1FeeUpperBound to GasPriceOracle #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdehoog
reviewed
Mar 19, 2024
| /// @param _unsignedTxSize Unsigned fully RLP-encoded transaction size to get the L1 fee for. | ||
| /// @return L1 estimated upper-bound fee that should be paid for the tx | ||
| function getL1FeeUpperBound(uint256 _unsignedTxSize) external view returns (uint256) { | ||
| require(isFjord, "GasPriceOracle: getL1FeeUpperBound only supports Fjord"); |
There was a problem hiding this comment.
i think we probably don't need this given it won't be available before fjord, but don't feel strongly
mdehoog
reviewed
Mar 19, 2024
|
@mdehoog 💇
|
mdehoog
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
getL1FeeUpperBoundbased on the spec: https://github.com/ethereum-optimism/specs/pull/25/filesOpen question: @mdehoog my understanding is this function will only be live when we have Fjord upgraded so this should be Fjord exclusive.