forked from ethereum-optimism/optimism
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Millisecond Blocktimes #10
Closed
fahimahmedx
wants to merge
34
commits into
base-org:sub-second-block-times
from
fahimahmedx:milliseconds-data-type
Closed
Millisecond Blocktimes #10
fahimahmedx
wants to merge
34
commits into
base-org:sub-second-block-times
from
fahimahmedx:milliseconds-data-type
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…use timeint.Seconds
….Time values into milliseconds
…when turning into milliseconds
…t for adding Milliseconds to PayloadAttributes struct
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo
ExecutionPayload
to haveMilliseconds
field, as implemented in my op-gethL2BlockRef.Time
to useExecutionPayload.Milliseconds
cfg.isEcotone()
to take inExecutionPayload.Milliseconds
instead ofExecutionPayload.Seconds
PayloadAttributes
to haveMilliseconds
fieldAttributesMatchBlock()
to check based on theMillisecond
fields ofExecutionPayload
andPayloadAttributes
SpanBatch
to useMilliseconds
SingularBatch
to useMilliseconds
MarshalSSZ()
andUnmarshalSSZ()
inop-service/eth/ssz.go
to includeMilliseconds
, and include test cases inssz_test.go
PayloadInfo.Timestamp to use
timeint.Milliseconds` datatypecomputePayloadId()
inl2_engine_api.go
needs to be modified to supportMilliseconds
field inPayloadInfo
.