Move CA bundle validation into NitroValidator contract #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdehoog
commented
Jan 11, 2025
| VerifiedCert memory parent; | ||
| for (uint256 i = 0; i < cabundle.length; i++) { | ||
| bytes32 certHash = keccak256(cabundle[i]); | ||
| require(i > 0 || certHash == ROOT_CA_CERT_HASH, "Root CA cert not matching"); |
There was a problem hiding this comment.
This check has been removed. It should be covered by the checks inside the certHash != ROOT_CA_CERT_HASH conditional in _verifyCert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
CertManagercontract is too big for deployment, due to recent changes from audit.This PR moves the cabundle loop into the NitroValidator contract, and splits CA and client cert verification into separate methods.