Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo Fixes in Makefile and SetupNewProposer.s.sol #241

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

teenager-ETH
Copy link

Pull Request: Typo Fixes in Makefile and SetupNewProposer.s.sol

Description

This pull request addresses multiple minor typos found in the Makefile and SetupNewProposer.s.sol. The changes ensure clarity and correctness in the documentation and code comments.

Changes Made:

  1. Makefile:
    • Corrected the spelling of "transfering" to "transferring".
  2. SetupNewProposer.s.sol:
    • Corrected the spelling of "wiht" to "with".

Files Modified

  1. mainnet/2023-07-26-transfer-owner-nested-safes/Makefile:
    • 2 additions
    • 2 deletions
  2. setup-templates/template-incident/script/SetupNewProposer.s.sol:
    • 2 additions
    • 2 deletions

Before and After:

Makefile

  • Before:

    Commands for transfering ownership of L1 and L2 contracts to corresponding nested multisigs

  • After:

    Commands for transferring ownership of L1 and L2 contracts to corresponding nested multisigs

SetupNewProposer.s.sol

  • Before:

    Deploy L2OutputOracle new implementation wiht the new submission interval

  • After:

    Deploy L2OutputOracle new implementation with the new submission interval

Author

Review Checklist

  • Verify the typos have been corrected.
  • Confirm no additional changes were made beyond those described.
  • Approve and merge if no further issues are found.

Thank you for reviewing!

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Dec 23, 2024

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 -1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

# 281ebc7c95ca7f3f7572275638f0c4c9766a71cbb32b9602260246340c354af02e127b85e216d4144d39fb4f191df6d38e440a13805a1999df149a8fce33fad61c
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@teenager-ETH There should be no diff here

Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@teenager-ETH Thanks for this PR; left a comment in-line

@wbnns wbnns added the change(s) requested One or more changes have been requested label Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change(s) requested One or more changes have been requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants