fix: allow beacon api req/res to use JSON #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x00101010
reviewed
Apr 10, 2024
| @@ -19,7 +20,7 @@ func NewBeaconClient(ctx context.Context, cfg flags.BeaconConfig) (Client, error | |||
| cctx, cancel := context.WithCancel(ctx) | |||
| defer cancel() | |||
|
|
|||
| c, err := http.New(cctx, http.WithAddress(cfg.BeaconURL), http.WithTimeout(cfg.BeaconClientTimeout)) | |||
| c, err := http.New(cctx, http.WithAddress(cfg.BeaconURL), http.WithTimeout(cfg.BeaconClientTimeout), http.WithEnforceJSON(cfg.EnforceJSON), http.WithLogLevel(zerolog.ErrorLevel)) | |||
There was a problem hiding this comment.
nit: should we make the log level configurable? is error level enough?
There was a problem hiding this comment.
The logs that this client outputs are mostly duplicated with the service logs (e.g. here).
It also doesn't hook into oplog and as such don't format nicely -- so I figured it was worth preferring the services logs over the libraries.
That being said -- I don't have a strong opinion here. Happy to keep them in if you prefer.
There was a problem hiding this comment.
I trust your judgement here. thanks!
roberto-bayardo
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently when using the go-eth-2 client to fetch blob sidecars it results in an error when dividing the response into sections here.