Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed unnecessary closing parenthesis Update EDAPrice.sol #111

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mdqst
Copy link

@mdqst mdqst commented Dec 31, 2024

I’ve removed an extra closing parenthesis in the comment where the function description was incorrectly formatted.
The line in question was:

/// @dev reverts if lnWad(percentWadRemainingPerPeriod) * ratio) overflows

The additional parenthesis after ratio didn’t make sense and caused confusion.

Based!

@cb-heimdall
Copy link
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@mdqst
Copy link
Author

mdqst commented Jan 21, 2025

@brendan-defi @wbnns Hey! Could you please review my corrections?

I hope I was able to help in some way.

Based.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants