Update ci.yml for node v18

bartstc · Oct 22, 2023 · 7550a6a · 7550a6a
1 parent b85ff6a
commit 7550a6a
Showing 1 changed file with 9 additions and 8 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -33,11 +33,12 @@ jobs:
           version: 8
           run_install: false
 
-      - name: Install Node.js
-        uses: actions/setup-node@v3
-        with:
-          node-version: "16.x"
-          cache: "pnpm"
+      # https://github.com/storybookjs/test-runner/issues/301
+      # - name: Install Node.js
+      #   uses: actions/setup-node@v3
+      #   with:
+      #     node-version: "16.x"
+      #     cache: "pnpm"
 
       - name: Get pnpm store directory
         id: pnpm-cache
@@ -57,7 +58,7 @@ jobs:
         run: pnpm install --no-frozen-lockfile --ignore-scripts
 
       - name: Install Playwright
-        run: npx playwright install --with-deps
+        run: pnpm exec playwright install --with-deps
 
       - name: Build Storybook
         run: pnpm build-storybook --quiet
@@ -66,7 +67,7 @@ jobs:
         run: |
           pnpm exec concurrently -k -s first -n "SB,TEST" -c "magenta,blue" \
             "pnpm exec http-server storybook-static --port 6006 --silent" \
-            "pnpm exec wait-on tcp:6006 && pnpm exec test-storybook --json --outputFile storybook-report.json a"
+            "pnpm exec wait-on tcp:127.0.0.1:6006 && pnpm exec test-storybook --json --outputFile storybook-report.json a"
 
       - name: Upload json report artifacts
         uses: actions/upload-artifact@v3
@@ -127,7 +128,7 @@ jobs:
       - name: Get build artifacts
         uses: actions/download-artifact@v3
         with:
-          name: build # will download a zipped build and unzip it
+          name: build
       - name: Outputs content
         run: ls
       - name: Deploy