Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript #92

Merged
merged 11 commits into from
Apr 24, 2024
Merged

Typescript #92

merged 11 commits into from
Apr 24, 2024

Conversation

lil5
Copy link
Contributor

@lil5 lil5 commented Apr 23, 2024

#89

@lil5
Copy link
Contributor Author

lil5 commented Apr 23, 2024

there are so many bugs hidden in the js that are now visible, still a wip and currently only changes the webapp

@lil5 lil5 marked this pull request as ready for review April 24, 2024 07:53
@lil5 lil5 mentioned this pull request Apr 24, 2024
Copy link
Owner

@balzack balzack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me, and the local tests all work. Thanks!

@balzack
Copy link
Owner

balzack commented Apr 24, 2024

I really appreciate your improvements and guidance. Thank you.

@balzack
Copy link
Owner

balzack commented Apr 24, 2024

The github action is failing, but I think it can be resolved by changing actions/setup-node@v3 to 18

Since all the tests work locally, I'll merge and update the main repo.

@balzack balzack merged commit 71c65ef into balzack:main Apr 24, 2024
1 check failed
balzack pushed a commit that referenced this pull request May 2, 2024
This reverts commit 71c65ef.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants