feat(): add vue2 support using vue-demi dependency #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Toilal
force-pushed
the
vue-demi
branch
6 times, most recently
from
8a04d99 to
c2ae4db
Compare
DmitryFinX
approved these changes
Oct 25, 2021
|
I kinda like the fact it is Vue 3 only. What's wrong with dsb-norge/vue-keycloak-js for Vue 2 (Vue 3 support is in beta) ? |
|
Nothing's wrong with this other package, but I use composition API in a vue 2 project. This package is a better fit if final app is using composition API, no matter Vue version. That beeing said i'll understand if you don't want to maintain vue 2 inside this repository. Feel free to choose 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I still have to use vue 2 for now, so I wrote this fork to bring support vue2 / @vue/composition-api support thanks to vue-demi.