Skip to content

Commit

Permalink
🐛 fix(bal-dropdown): Dropdown values are submitted twice (#1588)
Browse files Browse the repository at this point in the history
* Create PR for #1585

* fix(dropdown): only submit value ones

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Gery Hirschfeld <[email protected]>
  • Loading branch information
github-actions[bot] and hirsch88 authored Jan 31, 2025
1 parent 7a058e0 commit 911b75f
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
5 changes: 5 additions & 0 deletions .changeset/short-planes-hug.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@baloise/ds-core': patch
---

**dropdown**: only submit value ones
1 change: 0 additions & 1 deletion packages/core/src/components/bal-dropdown/bal-dropdown.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -513,7 +513,6 @@ export class Dropdown
></DropdownValue>
</span>
<DropdownInput
name={this.name}
inputId={this.inputId}
httpFormSubmit={this.httpFormSubmit}
ariaForm={this.ariaForm}
Expand Down
3 changes: 0 additions & 3 deletions packages/core/src/utils/dropdown/input.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import { BalLanguage } from '../config'
import { Attributes } from '../attributes'

export interface DropdownInputProps {
name: string
inputId: string
httpFormSubmit: boolean
ariaForm: BalAriaForm
Expand All @@ -30,7 +29,6 @@ export interface DropdownInputProps {
}

export const DropdownInput: FunctionalComponent<DropdownInputProps> = ({
name,
inputId,
httpFormSubmit,
ariaForm,
Expand Down Expand Up @@ -63,7 +61,6 @@ export const DropdownInput: FunctionalComponent<DropdownInputProps> = ({
size={1}
inputmode="none"
tabindex="0"
name={name}
autoComplete={autocomplete}
value={rawValue.join(',')}
required={required}
Expand Down

0 comments on commit 911b75f

Please sign in to comment.