Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace synchronized block with Lock #2265

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Replace synchronized block with Lock #2265

wants to merge 5 commits into from

Conversation

TharmiganK
Copy link
Contributor

@TharmiganK TharmiganK commented Jan 7, 2025

Purpose

$Subject

Completes: ballerina-platform/ballerina-library#7488

Tests

Checked with the following number of users with 50B payload. Worked without any hanging issues

  • 200
200-users
  • 300
300-users
  • 500
500-users
  • 600
600-users

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility
  • Checked the impact on OpenAPI generation

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.83%. Comparing base (b58e52d) to head (28745f6).

Files with missing lines Patch % Lines
...rt/contractimpl/sender/http2/Http2ChannelPool.java 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2265      +/-   ##
============================================
- Coverage     80.48%   79.83%   -0.65%     
- Complexity        0      678     +678     
============================================
  Files           366      418      +52     
  Lines         20749    23122    +2373     
  Branches       3289     3750     +461     
============================================
+ Hits          16700    18460    +1760     
- Misses         3119     3526     +407     
- Partials        930     1136     +206     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TharmiganK TharmiganK marked this pull request as ready for review January 7, 2025 09:39
Copy link

sonarqubecloud bot commented Jan 8, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant