-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for io.balena.update.requires-reboot
label
#2381
Conversation
53d0fd3
to
ad128fc
Compare
60e4011
to
1506adc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good on initial pass. Will do another pass on Mon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did another pass -- the changes make sense. Great work 👍🏼
Move the device-config module to the device-state folder and export only those functions that are needed elsewhere in the codebase This moves us closer to making the device-state module the only way to modify application and configuration. Change-type: patch
This was on device-config before, but we'll need to set the reboot breadcrumb from the application-manager as well when we introduce `requires-reboot` as a label. Change-type: patch
6e1ce06
to
e8ce10d
Compare
io.balena.update.reboot-required
labelio.balena.update.requires-reboot
label
This label can be used by user services to indicate that a reboot is required after the install of a service in order to fully apply an update. Change-type: minor
e8ce10d
to
e416ad0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
This label can be used by user services to indicate that a reboot is required after the install of a service in order to fully apply an update. In particular, this will be used by hostOS updates when we add this feature on the supervisor.
Change-type: minor
Depends-on: #2389
Release notes
This release adds support for a new docker-compose label:
io.balena.update.requires-reboot
. When the label is present on a service, it tells the supervisor that a system reboot should be performed before starting the service for the first time.When a target release is received that contains services with this label, the supervisor will
Note that the supervisor cannot distinguish between a first time install of the service or the container being re-created. This means that actions that re-create services will also require a reboot. Ex: restart service, purge data, disable local-mode will all re-create containers and hence require a reboot.