Create mechanism to read files from host / #2082
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The supervisor needs to read some files from the host root since there are no alternative interfaces that the host provides. These files are - /etc/os-release to read the OS version - /run/openvpn/vpn_status/active to check the VPN status While we are working to introduce alternative interfaces for reading the information provided by these files, the supervisor still needs a backwards compatible way to get that info. This PR uses the fact that the supervisor has access to the docker socket to mount a file into a container and read the file from there. Change-type: minor
This removes VPN status monitoring, which would be too expensive to do with a container and is really not necessary. The VPN status information will be available for requests via the supervisor API.
pipex
force-pushed
the
read-from-root
branch
from
91775fc to
45d678f
Compare
|
TODO
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The supervisor needs to read some files from the host root since there are no alternative interfaces that the host provides. These files are
While we are working to introduce alternative interfaces for reading the information provided by these files, the supervisor still needs a backwards compatible way to get that info.
This PR uses the fact that the supervisor has access to the docker socket to mount a file into a container and read the file from there.
Change-type: minor