Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loki: use structured metadata rather than a JSON line #1918

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Page-
Copy link
Contributor

@Page- Page- commented Dec 24, 2024

Change-type: major

const structuredMetadata = [
deviceId,
new loki.LabelPairAdapter()
.setName('timestamp')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we name this piece of metadata as "device_timestamp" instead to make it clearer what it actually is?

@Page- Page- force-pushed the loki-structured-metadata branch from a3ee777 to d86e792 Compare December 24, 2024 14:48
const structuredMetadata = [
deviceId,
new loki.LabelPairAdapter()
.setName('timestamp')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also questionable as to whether we should store it as structured metadata because every entry for it will be unique and possibly make a bunch of other things more painful and is probably not ergonomic or even useful to query by

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant