Skip triggering device update checks for image env var POSTs of non-successful releases #1794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thgreasi
force-pushed
the
image-env-var-device-update-trigger
branch
from
d9153ed to
a13ed02
Compare
…ar POSTs of non-successful releases Change-type: patch
thgreasi
force-pushed
the
image-env-var-device-update-trigger
branch
from
a13ed02 to
abd32e8
Compare
thgreasi
commented
Oct 17, 2024
| // with high planning time. The idea is that image env vars are created | ||
| // while the release is still 'running', in which case we don't expect | ||
| // any device to possibly be running that release. | ||
| const isPartOfSuccessfulRelease = |
There was a problem hiding this comment.
Someone could even argue that we could just never check for affected devices on image env var POSTs at all,
since if someone does end up doing image env var POSTs after the release gets finalized (which we don't expect), then the devices will anyway fetch them on their next scheduled state GET poll.
|
#1796 might be a better approach |
|
Closing in favor of #1796 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-type: patch