Fix typo in /v2/applications/:appId/restart-service Supervisor API call #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cywang117
force-pushed
the
fix-supervisor-restart_service-call
branch
4 times, most recently
from
4d36992 to
b2da471
Compare
|
Something is wrong with the tests, specifically the log unsubscribe function, despite my efforts to get them patched, will revisit in case it's a transient issue with the API. If anyone knows what the issue is and can get this to work, please feel free to push or fixup my test-fixing commit. |
cywang117
force-pushed
the
fix-supervisor-restart_service-call
branch
from
b2da471 to
ddcf79d
Compare
otaviojacobi
approved these changes
May 24, 2024
Change-type: patch Closes: #354 Signed-off-by: Christina Ying Wang <[email protected]>
Signed-off-by: Christina Ying Wang <[email protected]>
cywang117
force-pushed
the
fix-supervisor-restart_service-call
branch
from
ddcf79d to
8678bc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API endpoint being called was
/v2/applications/:appId/restart_service(with underscore) when it should be/v2/applications/:appId/restart-service(with dash).Change-type: patch
Closes: #354