Enable dual stack support for balena tunnel #2908
Draft
+198
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `balena tunnel`commands uses `localhost` as the default listening address. The problem is that on some dual stack networks (IPv4/IPv6), this can result on the tunneling server only binding to `::1` and not to `127.0.0.1`, potentially causing issues as this behavior is not intuitive. This PR replaces the default server name with `::` which setups the server in dual-stack mode. Change-type: patch
|
Note that this may have some security implications as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
balena tunnelcommands useslocalhostas the default listening address. The problem is that on some dual stack networks (IPv4/IPv6), this can result on the tunneling server only binding to::1and not to127.0.0.1, potentially causing issues as this behavior is not intuitive.This PR replaces the default server name with
::which setups the tunneling server in dual-stack mode.Change-type: patch