nginx: Mask nginx service after install #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have tested, works fine, and now doesn't cause either UI or Admin to fail to restart! |
Page-
approved these changes
Mar 27, 2019
Dockerfile
Outdated
| @@ -16,3 +16,6 @@ RUN echo 'deb http://deb.debian.org/debian jessie main' >> /etc/apt/sources.list | |||
| && rm /etc/init.d/nginx \ | |||
| && rm -rf /etc/nginx/conf.d/* \ | |||
| && rm -rf /var/lib/apt/lists/* | |||
|
|
|||
| # Stop nginx from being available, as we run it manually in downstream images | |||
| RUN systemctl mask nginx.service | |||
There was a problem hiding this comment.
Wanna whack this in as part of the last RUN?
There was a problem hiding this comment.
Yeah, that makes sense, shall edit!
Connects-to: #34 Change-type: patch Signed-off-by: Heds Simons <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects-to: #34
Change-type: patch
Signed-off-by: Heds Simons [email protected]